refactor: consume the split comline-codegen crates - #19
Merged
Conversation
Follows generation's split (comline-codelib-gen -> comline-codegen + comline-codegen-rust + comline-codegen-typescript). - Cargo.toml: one git dep -> three. - generate.rs: build a Registry at startup from the per-language crates (generator_registry()); code_gen::find_generator -> registry.find. - clean.rs: same registry, reused. The feature-gating of the registered set is rollout step 6; here both generators are always registered. Build clean; 36 + 2 tests pass; fmt clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows generation#8 —
comline-codelib-gensplit intocomline-codegen(contract +Registry) +comline-codegen-rust+comline-codegen-typescript.Cargo.toml— onegenerationgit dep becomes three, all pinned to generation master8ff03d7. Onecomline-corein the tree still (aa84d970).generate.rs—generator_registry()builds aRegistryat startup by calling each per-language crate'sregister(&mut Registry);code_gen::find_generator(...)→registry.find(...).clean.rs— reusesgenerator_registry().Feature-gating which generators get registered is rollout step 6; here both are always on.
No behaviour change. Local: builds clean, 36 + 2 tests pass,
cargo fmt --checkclean.